check imap attachment symlink on the resolved destination path#69194
Open
Samin061 wants to merge 1 commit into
Open
check imap attachment symlink on the resolved destination path#69194Samin061 wants to merge 1 commit into
Samin061 wants to merge 1 commit into
Conversation
potiuk
added
the
ready for maintainer review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ImapHook writes each downloaded attachment under
local_output_directory, but_is_symlinkpassed the bare attachment name toos.path.islink, so it inspected a path relative to the process working directory rather than the file that gets opened. A symlink planted at the real destination slipped past the check and the followingopen(..., "wb")wrote through it, so an attacker-controlled attachment name and payload could overwrite the link target. Resolve the destination with_correct_pathbefore the symlink check so the file actually being written is the one inspected.Was generative AI tooling used to co-author this PR?